Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test-suite): failing tests due to replication latency #500

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Aug 22, 2022

Issue being fixed or feature implemented

Tests are failing in different places due to replication latency. Nodes have different chain tips and if one node responds with state transition results it doesn't mean that other nodes have already replicated and executed the corresponding block.

What was done?

  • Enabled wait logic for all networks, not just testnet. Make this interval configurable
  • Replaced toJSON with toObject

How Has This Been Tested?

Running tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.23.0 milestone Aug 22, 2022
@shumkov shumkov requested a review from antouhou as a code owner August 22, 2022 08:53
Copy link
Collaborator

@shuplenkov shuplenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow!

@shumkov shumkov merged commit 6df6a9a into v0.23-dev Aug 22, 2022
@shumkov shumkov deleted the wait-for-st-propagated branch August 22, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants