-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: test suite image and environment problems in ci #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
reviewed
Aug 25, 2022
pshenmic
reviewed
Aug 26, 2022
pshenmic
previously approved these changes
Sep 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤙🤙
shumkov
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Test suite was failing in CI with
DAPI_SEED=yarn NETWORK=testnet
and a hang. This is due to a bug (?) introduced in #416 wheretest.sh
is used as an entrypoint without reading environment vars passed in a.env
file.When this is fixed, the tests still fail with:
Removing the
ENTRYPOINT
from the Dockerfile resolves the problem, why is this entrypoint necessary?What was done?
source .env
file if it exists--inspect-brk
debug mode from mochaENTRYPOINT
from DockerfileHow Has This Been Tested?
Local builds
Breaking Changes
??
Checklist:
For repository code-owners and collaborators only