New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: add an ability to update data contract #52

Merged

jawid-h merged 44 commits into v0.22-dev from feat/update-contract

Dec 7, 2021

Collaborator

jawid-h commented Nov 23, 2021 •

edited

Loading

Issue being fixed or feature implemented

To be able to make some updates in your contract without loosing the existing data

What was done?

implemented DataContractUpdateTransition
implemented update method in SDK

How Has This Been Tested?

local dev env
unit tests

Breaking Changes

platform.contracts.broadcast method in SDK renamed to platform.contracts.publish

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have made corresponding changes to the documentation

For repository code-owners and collaborators only

I have assigned this pull request to a milestone

jawid-h added 7 commits

November 23, 2021 18:46


          chore: install json-schema-diff-validator

6efecef


          feat: implement DataContractUpdateTransition

ebfe806


          chore: update state transition calls

589edea


          chore: update SDK to support update of a contract

a28ebfe


          Merge branch 'v0.22-dev' into feat/update-contract

5b56792


          chore: update broadcast calls

0cf6ad2


          chore: fixes and suite tests

b9a584e

shumkov changed the title ~~feat(dpp): implement DataContractUpdateTransition~~ feat: update data contract

shumkov reviewed

View reviewed changes

...ontractUpdateTransition/validation/basic/validateDataContractUpdateTransitionBasicFactory.js Outdated Show resolved Hide resolved

shumkov reviewed

View reviewed changes

...ontractUpdateTransition/validation/state/validateDataContractUpdateTransitionStateFactory.js Outdated Show resolved Hide resolved

shumkov reviewed

View reviewed changes

...tateTransition/DataContractUpdateTransition/validation/state/validateIndicesAreNotChanged.js Outdated Show resolved Hide resolved

shumkov reviewed

View reviewed changes

packages/js-dpp/lib/errors/consensus/state/dataContract/IncompatibleDataContractSchemaError.js Outdated Show resolved Hide resolved

shumkov reviewed

View reviewed changes

packages/js-dpp/lib/errors/consensus/state/dataContract/InvalidDataContractBaseDataError.js Outdated Show resolved Hide resolved

shumkov reviewed

View reviewed changes

packages/js-dpp/schema/dataContract/dataContractMeta.json Outdated Show resolved Hide resolved

jawid-h added 3 commits

November 26, 2021 16:21


          chore: PR comments update

abfc6f0


          chore: PR comments

c35f6e3


          chore: PR comments

shumkov reviewed

View reviewed changes

packages/js-dash-sdk/docs/examples/updating-a-contract.md Outdated Show resolved Hide resolved

packages/js-dpp/lib/dataContract/DataContract.js Show resolved Hide resolved

...js-dpp/lib/errors/consensus/basic/dataContract/DataContractImmutablePropertiesUpdateError.js Outdated Show resolved Hide resolved

jawid-h added 6 commits

November 29, 2021 13:29


          chore: PR comments

cdcfbd5


          Merge branch 'v0.22-dev' into feat/update-contract

f30a63e


          chore: updated deps after yarn install

84cdc5d


          chore: PR comments

9e6cc86


          chore: update a doc

699d177


          chore: update st call

8991b7a

shumkov reviewed

View reviewed changes

...js-dpp/lib/errors/consensus/basic/dataContract/DataContractImmutablePropertiesUpdateError.js Outdated Show resolved Hide resolved

shumkov reviewed

View reviewed changes

packages/js-dpp/lib/errors/consensus/basic/dataContract/IncompatibleDataContractSchemaError.js Outdated Show resolved Hide resolved

shumkov reviewed

View reviewed changes

packages/platform-test-suite/test/functional/platform/DataContract.spec.js Show resolved Hide resolved

jawid-h added 3 commits

November 29, 2021 15:44


          PR: comments

7902c49


          chore: fixture

8876b6a


          chore: test

656b43f

jawid-h requested a review from shumkov

November 29, 2021 16:10

shumkov reviewed

View reviewed changes

...js-dpp/lib/errors/consensus/basic/dataContract/DataContractImmutablePropertiesUpdateError.js Outdated Show resolved Hide resolved


          chore: error update

jawid-h requested a review from shumkov

November 30, 2021 06:24

shumkov reviewed

View reviewed changes

packages/js-dash-sdk/docs/platform/contracts/update.md Outdated Show resolved Hide resolved


          chore: update doc

b3a89be

shumkov requested changes

View reviewed changes

...tateTransition/DataContractUpdateTransition/validation/basic/validateIndicesAreNotChanged.js Outdated Show resolved Hide resolved

...tateTransition/DataContractUpdateTransition/validation/basic/validateIndicesAreNotChanged.js Outdated Show resolved Hide resolved

...js-dpp/lib/errors/consensus/basic/dataContract/DataContractImmutablePropertiesUpdateError.js Outdated Show resolved Hide resolved

packages/js-dpp/lib/errors/consensus/basic/dataContract/IncompatibleDataContractSchemaError.js Outdated Show resolved Hide resolved

jawid-h added 2 commits

December 1, 2021 15:47


          chore: simplify index validation

67d67dd


          chore: error simplification

afc3287

shumkov reviewed

View reviewed changes

packages/js-dash-sdk/docs/platform/contracts/update.md Outdated Show resolved Hide resolved

jawid-h added 2 commits

December 1, 2021 16:49


          chore: remove async

dea2fca


          chore: doc update

89273f6

jawid-h requested a review from shumkov

December 1, 2021 12:00

shumkov changed the title ~~feat(dpp)!: add an ability to update data contract~~ feat!: add an ability to update data contract

jawid-h and others added 11 commits

December 2, 2021 14:42


          chore: allow new doc indices

f4590ba


          chore: validation update

01f49f0


          Merge branch 'v0.22-dev' into feat/update-contract

69eda71


          chore: yarn updates

89463f2


          chore: trying to update cache

1b6db30


          chore: fix

7463c90


          chore: more credits

9f70778


          chore: finalization

f69be42


          chore: fix tests

9bbb5c1


          refactor: move newly created contracts to the place of using

acfc53b


          chore: fix tests

921e273

shumkov approved these changes

View reviewed changes

Member

shumkov left a comment

Good job! 👍

jawid-h merged commit 0e0df30 into v0.22-dev

jawid-h deleted the feat/update-contract branch

December 7, 2021 13:45

thephez added this to the v0.22.0 milestone

qrayven mentioned this pull request

feat: [v23 port] data contract indices validation dashevo/rust-dpp#26

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet