Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet-lib): do not sync transactions if mnemonic is absent #7

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

jawid-h
Copy link
Collaborator

@jawid-h jawid-h commented Nov 3, 2021

Issue being fixed or feature implemented

This change eliminates unnecessary synchronization of transactions in case wallet has been generated from the new mnemonic

What was done?

Check if the wallet has been generated from the new mnemonic and sync transactions from the best block (instead of block 1 or the one provided via unsafeOptions: { skipSynchronizationBeforeHeight: <n> })

How Has This Been Tested?

  • Passed no mnemonic to the Wallet initialization arguments
  • Ensured quick initialization time
  • Hooked on account events and ensured that synchronization of the new blocks works properly

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h added this to the v0.22.0 milestone Nov 3, 2021
@shumkov shumkov merged commit 7d14553 into v0.22-dev Nov 3, 2021
@shumkov shumkov deleted the feat/do-not-sync-in-abscence-of-mnemonic branch November 3, 2021 15:08
shumkov pushed a commit that referenced this pull request Nov 23, 2022
feat: type deserialization + encoding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants