Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix wrong version in PR title #82

Merged
merged 3 commits into from
Dec 21, 2021
Merged

chore: fix wrong version in PR title #82

merged 3 commits into from
Dec 21, 2021

Conversation

shuplenkov
Copy link
Collaborator

@shuplenkov shuplenkov commented Dec 13, 2021 •
edited
Loading

Issue being fixed or feature implemented

Release PR contains previous version instead of the new one

What was done?

Fixed release script

How Has This Been Tested?

Manual

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.21.x milestone Dec 13, 2021
@shuplenkov shuplenkov changed the title build: fix bash syntax issue in release script build: fix wrong version in PR title Dec 13, 2021
shumkov
shumkov requested changes Dec 14, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to fix in master branch fix.

@shuplenkov shuplenkov changed the base branch from v0.22-dev to master December 15, 2021 15:11
shumkov
shumkov approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov changed the title build: fix wrong version in PR title chore: fix wrong version in PR title Dec 15, 2021
@shumkov shumkov merged commit f3c3606 into master Dec 21, 2021
@shumkov shumkov deleted the fix-release branch December 21, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.21.x
Development

Successfully merging this pull request may close these issues.
2 participants
@shuplenkov @shumkov