change bitcore to dashcore and update dashcore-lib dependency #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmarley
reviewed
Dec 27, 2018
lib/messages/commands/version.js
Outdated
| @@ -37,7 +37,7 @@ function VersionMessage(arg, options) { | |||
| this.nonce = arg.nonce || utils.getNonce(); | |||
| this.services = arg.services || new BN(1, 10); | |||
| this.timestamp = arg.timestamp || new Date(); | |||
| this.subversion = arg.subversion || '/bitcore:' + packageInfo.version + '/'; | |||
| this.subversion = arg.subversion || '/@dashcore/dashcore-p2p:' + packageInfo.version + '/'; | |||
There was a problem hiding this comment.
Should this not be "dashcore" per the documentation above? Although it would get confusing with "Dash Core" I guess...
There was a problem hiding this comment.
good catch! It's like a UserAgent info I guess. I'll put it to 'dashcore'. If it causes confusion we can still change it easily later on.
|
re-utACK @ e997ed6 |
|
Please use "Squash and Merge" option when merging this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context preparing for a new Insight-api release, I found that dashcore-p2p is a dev dependency of dashcore-node. This is not very urgent, but would be nice to fix naming convention and dependency vulnerabilities (next PR) before release. I will bump the version once vulnerabilities are fixed.