Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Harden DEPLOYMENT_V20 activation #6186

Closed
PastaPastaPasta opened this issue Aug 9, 2024 · 1 comment
Closed

refactor: Harden DEPLOYMENT_V20 activation #6186

PastaPastaPasta opened this issue Aug 9, 2024 · 1 comment
Assignees
@knst
Milestone
21.2

Comments

@PastaPastaPasta
Copy link
Member

see

dash/src/chainparams.cpp

Lines 588 to 594 in dfe7089

consensus.vDeployments[Consensus::DEPLOYMENT_V20].bit = 9;
consensus.vDeployments[Consensus::DEPLOYMENT_V20].nStartTime = 1661990400; // Sep 1st, 2022
consensus.vDeployments[Consensus::DEPLOYMENT_V20].nTimeout = Consensus::BIP9Deployment::NO_TIMEOUT;
consensus.vDeployments[Consensus::DEPLOYMENT_V20].nWindowSize = 120;
consensus.vDeployments[Consensus::DEPLOYMENT_V20].nThresholdStart = 80; // 80% of 100
consensus.vDeployments[Consensus::DEPLOYMENT_V20].nThresholdMin = 60; // 60% of 100
consensus.vDeployments[Consensus::DEPLOYMENT_V20].nFalloffCoeff = 5; // this corresponds to 10 periods
; this has been active for a while, we should harden it in next major version
@PastaPastaPasta PastaPastaPasta added this to the 22 milestone Aug 9, 2024
@knst knst mentioned this issue Aug 26, 2024
Merged
5 tasks
PastaPastaPasta added a commit that referenced this issue Sep 10, 2024
@PastaPastaPasta
Merge #6225: feat: bury v20 fork - fire up test chains by first block…
6d42651 
… - 4/n

2381255 fix: possible deadlock during calculation of signals for historical blocks during re-index (Konstantin Akimov)
1087489 feat: bury v20 deployment (Konstantin Akimov)
64cedb3 feat: actually test something EHF unit tests (Konstantin Akimov)
762a808 chore: drop irrelevant bip9 code from feature_llmq_rotation.py (Konstantin Akimov)
7735631 fix: remove v20 from test feature_llmq_evo as far as mn_rr used (Konstantin Akimov)
ca83b26 fix: crash in CreditPool: it meant to check that DIP0003 is activated (Konstantin Akimov)

Pull request description:

  ## Issue being fixed or feature implemented
  V20 is activated on mainnet: time to bury it!

  #6186

  ## What was done?
  Hard-fork v20 is buried and it requires to implement multiple fixes, simplifications, refactoring:
   - some tests for EHF moved from functional tests to unit tests
   - fixed crash in Credit Pool if DIP3 is not activated yet
   - added a requirement for v20 activation for `CMNHFManager::GetSignalsStage`
   - removed useless code from functional test feature_llmq_rotation
   - renamed variables "v20" to "mn_rr" in feature_llmq_evo.py so far as actually used fork is mn_rr

  ## How Has This Been Tested?
  Some unit and functional tests to succeed.

  Done reindex  (just in case):

      src/qt/dash-qt -reindex  -assumevalid=0
      src/qt/dash-qt -reindex  -assumevalid=0 -testnet

  ## Breaking Changes
  N/A

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [x] I have commented my code, particularly in hard-to-understand areas
  - [x] I have added or updated relevant unit/integration/functional/e2e tests
  - [x] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone

ACKs for top commit:
  UdjinM6:
    ACK 2381255
  PastaPastaPasta:
    utACK 2381255

Tree-SHA512: eec35745baa695f3f286d39b6a61fa0a9f34820b13d1dd4cfbd1efe707850283892c39bf7fe49c49c812e0c02465d64df11480b3f12aa7f21b59a71eeae7260e
@knst knst modified the milestones: 22, 21.2 Sep 13, 2024
@knst
Copy link
Collaborator

knst commented Sep 13, 2024

Done: #6225

@knst knst closed this as completed Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knst knst

Labels
None yet
Projects
None yet
Milestone
21.2
Development

No branches or pull requests
2 participants
@knst @PastaPastaPasta