Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trigger execution and expiration #1920

Merged
merged 2 commits into from
Feb 12, 2018
Merged

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Feb 12, 2018

Actually execute triggers (was dropped in #1185). Keep executed triggers much longer (1 sb cycle).

@UdjinM6 UdjinM6 added this to the 12.3 milestone Feb 12, 2018
Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6
Copy link
Author

UdjinM6 commented Feb 12, 2018

Rebased to solve conflicts after merging #1915 (GetBlockStart() -> nBlockHeight), pls re-review

Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK 👍

Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit 580c488 into dashpay:develop Feb 12, 2018
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
* Move trigger expiration logic into CSuperblock and handle executed/non-executed triggers differently

* Actually execute triggers
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 28, 2019
* Move trigger expiration logic into CSuperblock and handle executed/non-executed triggers differently

* Actually execute triggers
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Mar 2, 2019
* Move trigger expiration logic into CSuperblock and handle executed/non-executed triggers differently

* Actually execute triggers
andvgal added a commit to energicryptocurrency/gen2-energi that referenced this pull request Oct 4, 2019
@UdjinM6 UdjinM6 deleted the fixtriggerexec branch November 26, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants