Don't use short version of 'tinyformat/fmt' namespace in util.h #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clion is not able to parse this correctly and messes up all the syntax checks, marking large parts of C++ files as syntactically invalid, making it hard to find real syntax errors without trying compilation.
|
Added an additional commit to do the same for strprintf in tinyformat.h I'm aware that tinyformat.h is not ours and a proper "fix" should probably be done in upstream. But I strongly doubt that such a change would be accepted as it is only useful for Clion users. Also, merge conflicts from upstream updates should be really easy to fix here, so I'd suggest to make an exception here. |
|
re-utACK |
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…pay#1975) * Don't use short version of 'tinyformat/fmt' namespace in util.h Clion is not able to parse this correctly and messes up all the syntax checks, marking large parts of C++ files as syntactically invalid, making it hard to find real syntax errors without trying compilation. * Also use full namespace name for strprintf in tinyformat.h
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 28, 2019
…pay#1975) * Don't use short version of 'tinyformat/fmt' namespace in util.h Clion is not able to parse this correctly and messes up all the syntax checks, marking large parts of C++ files as syntactically invalid, making it hard to find real syntax errors without trying compilation. * Also use full namespace name for strprintf in tinyformat.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clion is not able to parse this correctly and messes up all the syntax
checks, marking large parts of C++ files as syntactically invalid, making
it hard to find real syntax errors without trying compilation.