Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DarksendConfig #2132

Merged
merged 1 commit into from
Jul 12, 2018
Merged

Remove DarksendConfig #2132

merged 1 commit into from
Jul 12, 2018

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Jun 18, 2018

Turned out that it's not used now (due to a bug) and probably wasn't used at all since it was added 馃檲 We can either fix the bug and adjust the dialog OR remove this stuff completely. I think the later is a better option. Changes are pretty trivial but I'm postponing this till 12.4 just in case.

Kudos to @paulied for discovering this. Somewhat complimentary to #2128.

@UdjinM6 UdjinM6 added this to the 12.4 milestone Jun 18, 2018
Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Any plans to bring this back eventually, or just remove for good?

@UdjinM6
Copy link
Author

UdjinM6 commented Jun 18, 2018

Maybe we could extend intro dialog with Dash-specific settings instead or turn it into some kind of wizard if there is a need for that in short/mid term. In principle, I personally hope to see GUI part to be decoupled, moved to its own repo and then be completely rebuilt (maybe even from scratch and maybe not using Qt). But that's a very long term goal I'd say, so for now I just want to get rid of smth obsolete :)

@UdjinM6 UdjinM6 merged commit 3c89983 into dashpay:develop Jul 12, 2018
@UdjinM6 UdjinM6 deleted the removedsconfig branch November 26, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants