PrivateSend Enhancement: Up default round count to 4 and allow user to mix up to 16 rounds #2128
Conversation
All codebase appears to accept up to 16 rounds, however this form was capped at 8; restricting users to 2-8 rounds. This commit allows a user to actually use up to 16 rounds in practice. This will greatly enhance the privacy of those very worried about their privacy, as well as possibly increasing liquidity and increasing the privacy of all users.
|
Assigned 12.4 for now though this is a bit more complex issue than it seems at the first sight. When wallet is starting for the first time users are prompted with a config dialog ( Regarding default number of rounds, there are 3 options in |
|
@UdjinM6 I have used multiple installs of the core wallet, quite often. And I have never seen this In regards to the default, I had a local branch which had more PS changes than this commit has, but I am fairly sure that that branch (when compiled locally) did have the default at 4, and did appear to allow users to mix up to 16 rounds My VM for compiling is having problems, but once I get those smoothed out I'll test this branch and see how it acts |
|
Hmm... That's interesting... Looks like the code that should open |
|
Yeah, I just assumed that is was deprecated |
…o mix up to 16 rounds (dashpay#2128) * Allows a user to mix up to 16 rounds All codebase appears to accept up to 16 rounds, however this form was capped at 8; restricting users to 2-8 rounds. This commit allows a user to actually use up to 16 rounds in practice. This will greatly enhance the privacy of those very worried about their privacy, as well as possibly increasing liquidity and increasing the privacy of all users. * Up the default for PS mixing to 4 rounds.
This is intended for 12.4
This PR consists of 2 commits
1:
Allows a user to mix up to 16 rounds
It appears the entirety of the codebase supports up to 16 rounds, except for the form where you enter how many rounds you would like it to do. This commit changes that, and allows users to use the core wallet to mix up to 16 rounds. This will potentially increase the upper bound of privacy for users who are highly concerned, and could increase liquidity in general.
2:
Ups the default for PS mixing to 4 rounds. fixes #2055
Although 2 rounds of private send mixing does have its use case and is fine to use depending on the situation, it does not make a good default. Although the recent improvements to PrivateSend could make 2 rounds more viable and private, 2 rounds is generally accepted as not private to a sufficient degree. As such, myself and many community members believe that the default should be increased to not give users a false sense of security.