Move heavy coin selection out of the loop in SubmitDenominate #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| while (nStep < nStepsMax) { | ||
| for (const auto& pair: vecPSInOutPairsIn) { | ||
| if (pair.second.nRounds < nMinRounds || pair.second.nRounds > nMaxRounds) { |
There was a problem hiding this comment.
... pair.second.nRounds >= nMaxRounds ...
src/privatesend-client.cpp
Outdated
| std::vector< std::pair<CTxDSIn, CTxOut> > vecPSInOutPairs, vecPSInOutPairsTmp; | ||
|
|
||
| if (!SelectDenominate(strError, vecPSInOutPairs)) { | ||
| LogPrintf("CPrivateSendClientSession::SubmitDenominate -- SelectDenominate failed\n"); |
There was a problem hiding this comment.
... SelectDenominate failed, error: %s\n", strError);
src/privatesend-client.cpp
Outdated
| } | ||
| bool CPrivateSendClientSession::PrepareDenominate(int nMinRounds, int nMaxRounds, std::string& strErrorRet, const std::vector< std::pair<CTxDSIn, CTxOut> >& vecPSInOutPairsIn, std::vector< std::pair<CTxDSIn, CTxOut> >& vecPSInOutPairsRet) | ||
| { | ||
| if (!pwalletMain) { |
There was a problem hiding this comment.
Same 3 checks at the beginning of SelectDenominate. Redundant here?
UdjinM6
changed the title
UdjinM6
force-pushed
the
moveheavypartsout
branch
from
7fccdff
to
9bf753c
Compare
UdjinM6
force-pushed
the
moveheavypartsout
branch
from
9bf753c
to
938af06
Compare
|
rebased, pls review |
UdjinM6
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have to refactor quite a bit of code but the functionality should stay the same (logic wise).
Includes #2270 , will rebase after it's merged.