Squash two logic branches in SubmitDenominate into one #2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
force-pushed
the
squashlogic
branch
2 times, most recently
from
b4469a6
to
8cb7005
Compare
|
|
UdjinM6
changed the title
UdjinM6
force-pushed
the
squashlogic
branch
from
8cb7005
to
55650f9
Compare
UdjinM6
changed the title
|
rebased, pls review |
codablock
reviewed
Sep 12, 2018
| @@ -1175,51 +1175,44 @@ void CPrivateSendClientManager::ProcessPendingDsaRequest(CConnman& connman) | |||
|
|
|||
| bool CPrivateSendClientSession::SubmitDenominate(CConnman& connman) | |||
| { | |||
| // This is just a local helper | |||
| auto GetStartRound = [](bool fMixLowest, bool fScanFromTheMiddle) -> int | |||
There was a problem hiding this comment.
FYI, the -> int is luckely not required in most cases when using lambdas. It will guess the type based on the return statements found inside the lambda.
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should not change the behaviour.