-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Squash two logic branches in SubmitDenominate into one #2270
Conversation
b4469a6
to
8cb7005
Compare
|
8cb7005
to
55650f9
Compare
rebased, pls review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
@@ -1175,51 +1175,44 @@ void CPrivateSendClientManager::ProcessPendingDsaRequest(CConnman& connman) | |||
|
|||
bool CPrivateSendClientSession::SubmitDenominate(CConnman& connman) | |||
{ | |||
// This is just a local helper | |||
auto GetStartRound = [](bool fMixLowest, bool fScanFromTheMiddle) -> int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, the -> int
is luckely not required in most cases when using lambdas. It will guess the type based on the return statements found inside the lambda.
Should not change the behaviour.