Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IsBlockPayeeValid #2577

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Fix IsBlockPayeeValid #2577

merged 1 commit into from
Dec 21, 2018

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Dec 21, 2018

  • should skip while not synced regardless of spork15 state
  • add missing logprintf

@UdjinM6
Fix IsBlockPayeeValid
e2b67fa 
- should skip while not synced regardless of spork15 state
- add missing logprintf
@UdjinM6 UdjinM6 added this to the 13.0 milestone Dec 21, 2018
codablock
codablock approved these changes Dec 21, 2018
View reviewed changes
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, but this should be reverted as part of #2566

@UdjinM6
Copy link
Author

UdjinM6 commented Dec 21, 2018 •
edited
Loading

but this should be reverted as part of #2566

True but until then reindexing could fail without this patch applied ;)

@UdjinM6
Copy link
Author

UdjinM6 commented Dec 21, 2018

Actually, no, shouldn't be reverted - we can't rely on gobject data while not yet synced. This one is still not on-chain/deterministic.

@codablock
Copy link

Then instead of reverting, we should change it to only skip superblock verification on IBD/reindex and still do the MN payee checks.

@UdjinM6
Copy link
Author

UdjinM6 commented Dec 21, 2018

only skip superblock verification on IBD/reindex and still do the MN payee checks

Agree, this makes sense.

nmarley
nmarley approved these changes Dec 21, 2018
View reviewed changes
Copy link

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit 587911b into dashpay:develop Dec 21, 2018
@UdjinM6 UdjinM6 mentioned this pull request Jan 2, 2019
Merged
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Jun 29, 2020
@UdjinM6 @CryptoCentric
Fix IsBlockPayeeValid (dashpay#2577)
9f311d6 
- should skip while not synced regardless of spork15 state
- add missing logprintf
@UdjinM6 UdjinM6 deleted the fixIsBlockPayeeValid branch November 26, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmarley nmarley nmarley approved these changes

@codablock codablock codablock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@UdjinM6 @codablock @nmarley