Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DIP3 MNs in auto-IX tests #2588

Merged
merged 3 commits into from
Dec 31, 2018
Merged

Conversation

codablock
Copy link

@codablock codablock commented Dec 28, 2018

This currently builds on #2586. I'll rebase after it is merged.

This PR needs to be merged before we start removing of legacy/compatibility MN code.

Tests are quite slow atm as they need to mine 500 blocks and sync these to 13 nodes. I'll later optimize this by tweaking the DIP3 activation height for regtest (can't do this now as it might break other tests).

@codablock codablock added this to the 14.0 milestone Dec 28, 2018
@UdjinM6
Copy link

UdjinM6 commented Dec 28, 2018

looks good, will re-review after rebase

@UdjinM6
Copy link

UdjinM6 commented Dec 28, 2018

Needs rebase to drop #2586 (merged)

@codablock
Copy link
Author

Rebased and force-pushed.

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@codablock codablock merged commit 82745dd into dashpay:develop Dec 31, 2018
@codablock codablock deleted the pr_dip3_tests branch December 31, 2018 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants