Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A couple of fixes/refactorings for CDKGSessionHandler #2637

Merged
merged 6 commits into from
Jan 22, 2019
Merged

A couple of fixes/refactorings for CDKGSessionHandler #2637

merged 6 commits into from
Jan 22, 2019

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Jan 22, 2019

See individual commits

@UdjinM6 UdjinM6 added this to the 14.0 milestone Jan 22, 2019
codablock
codablock reviewed Jan 22, 2019
View reviewed changes
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a single nit, see inline comment/suggestion

src/llmq/quorums_dkgsessionhandler.cpp Outdated Show resolved Hide resolved
@codablock @UdjinM6
wrap % in ()
847e356 
Co-Authored-By: UdjinM6 <UdjinM6@users.noreply.github.com>
codablock
codablock approved these changes Jan 22, 2019
View reviewed changes
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit d2ddc2a into dashpay:develop Jan 22, 2019
@UdjinM6 UdjinM6 mentioned this pull request Jan 22, 2019
Merged
@UdjinM6 UdjinM6 deleted the llmqrefactor branch November 26, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codablock codablock codablock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@UdjinM6 @codablock