Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations v14 #2638

Merged
merged 8 commits into from
Apr 30, 2019
Merged

Translations v14 #2638

merged 8 commits into from
Apr 30, 2019

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Jan 22, 2019 •
edited by codablock
Loading

97%+ completion languages ([X] means 100%):

  • ar
  • bg
  • de
  • es
  • fi
  • fr
  • it
  • ja
  • ko
  • nl
  • pl
  • pt
  • ru
  • sk
  • th
  • tr
  • vi
  • zh_CN
  • zh_TW

@UdjinM6 UdjinM6 added this to the 14.0 milestone Jan 22, 2019
@UdjinM6 UdjinM6 force-pushed the translations201902 branch 2 times, most recently from 57001c3 to 4416a43 Compare March 25, 2019 17:01
@UdjinM6 UdjinM6 changed the title [WIP] Translations201902 [WIP] Translations v14 Mar 25, 2019
@UdjinM6 UdjinM6 mentioned this pull request Mar 26, 2019
Merged
@UdjinM6 UdjinM6 changed the title [WIP] Translations v14 Translations v14 Apr 26, 2019
@UdjinM6
Copy link
Author

UdjinM6 commented Apr 26, 2019

No changes on Transifex for ~2 weeks. I'd like to merge this and update remaining translations later. Pls review.

gladcow
gladcow reviewed Apr 26, 2019
View reviewed changes
src/qt/locale/dash_ru.ts Outdated Show resolved Hide resolved
gladcow
gladcow reviewed Apr 26, 2019
View reviewed changes
src/qt/locale/dash_ru.ts Outdated Show resolved Hide resolved
gladcow and others added 3 commits April 26, 2019 21:00
@UdjinM6
Update src/qt/locale/dash_ru.ts
81acffe 
Co-Authored-By: UdjinM6 <UdjinM6@users.noreply.github.com>
@UdjinM6
Update src/qt/locale/dash_ru.ts
516ddc0
@UdjinM6
update sk
1a52e0f
codablock
codablock previously approved these changes Apr 30, 2019
View reviewed changes
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

I however did some changes to the German language on Transifex...still not sure how the flow is with translations, but I assume you'll pull these changes in now? Or will will you merge and then create a new PR later with updates?

@UdjinM6
Copy link
Author

UdjinM6 commented Apr 30, 2019

Thanks 👍 Pulled de from Transifex.

@codablock
Copy link

@UdjinM6 added missing translations as well now, you might have missed those when pulling 🙈

@UdjinM6
update de
914d10c 
again :P
@UdjinM6
Copy link
Author

UdjinM6 commented Apr 30, 2019

Re-pulled :)

codablock
codablock approved these changes Apr 30, 2019
View reviewed changes
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit 3d993ee into dashpay:develop Apr 30, 2019
@UdjinM6 UdjinM6 deleted the translations201902 branch November 26, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gladcow gladcow gladcow left review comments

@codablock codablock codablock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@UdjinM6 @codablock @gladcow