Backports 0.15 pr5 #2647
Merged
Backports 0.15 pr5 #2647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
requested changes
Jan 25, 2019
PastaPastaPasta
force-pushed
the
backports-0.15-pr5
branch
from
d20f0a4
to
44a7134
Compare
UdjinM6
previously approved these changes
Jan 25, 2019
PastaPastaPasta
force-pushed
the
backports-0.15-pr5
branch
from
44a7134
to
c7cf788
Compare
|
I redid bitcoin#9905 and bitcoin#9832 after rebasing on latest develop, I dropped redirect_stderr as stderr param was introduced. Also, bitcoin#9871 is there, but was in pr3/4 and this wasn't based on one of those |
|
c7cf788 now removes |
|
I'm not seeing it being used in any tests @codablock, tests passing locally |
|
@PastaPastaPasta Just as an example: dash/qa/rpc-tests/wallet-dump.py Line 75 in 07dcddb Just do a global search for redirect_stderr and you'll find many more. Wondering how it can pass locally with redirect_stderr being ignored...it should even crash as it's an unknown named parameter now...I also noticed that initialize_chain also has this parameter.
|
PastaPastaPasta
force-pushed
the
backports-0.15-pr5
branch
from
0e0f7ab
to
9e25ad0
Compare
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Feb 1, 2019
PastaPastaPasta
force-pushed
the
backports-0.15-pr5
branch
from
9e25ad0
to
6a64d1c
Compare
90a1d9a Docs: add details to -rpcclienttimeout doc (Ian Kelling) Tree-SHA512: 7f9524f279a54b4d902674740d92624785abd54865aba82f7261151ceda50b5d51bf4d91c4fc0360168e190f8df890cc141bea5e1a9f4f2e62b8f9effda212cc
09fe346 Avoid -Wshadow warnings in wallet_tests (Russell Yanofsky) Tree-SHA512: 03a026787438efc9eba94299c2dd7de07a71ec7363b058b4f086d5ff0be844660fff2ef4f40e43d91313ea53de25f3de3c677b080b564d37f0693057498d3233
f36bdf0 Enable host lookups for -proxy and -onion parameters (Johnathan Corgan) Tree-SHA512: 40f5ef3954721333e58d34653874d9f6ac5426c817762d132838f3b6f968ca5ca05aa56d02fd742cb5a8dc040f1a28dad6d54f667342eceba62fb2af18b58fc0
e5b449c Docs: correct and elaborate -rpcbind doc (Ian Kelling) Tree-SHA512: e1cdaa32f7248f304d463e3f37d7d5da23ee0e506bd453420b87f4cc9c704cc30214e41c9266294890d65f2ee270f9355f38b542e8c01452637bdbba8273c755
…he end fa7da3f [contrib] gh-merge: Move second sha512 check to before signing (MarcoFalke) Tree-SHA512: b3d96f928a013f6fdc416035b8ef5cd7c750ab0922156e1fd712cd27ec75847497109f43a96559b945ba11ad43b5644ed9c1de695590ff608658628fb57b1571
343ba8f [wallet] Remove redundant initialization (practicalswift) Tree-SHA512: 54b94d7703b1735cb1ae0bd7eba61ca9d2f18e20b70e46c94aa3b0653495dce4fdea00cf953ec08215b96b5792eabb8b38c3f9b3cd36e52b82fcb2f1fd8a3540
PastaPastaPasta
force-pushed
the
backports-0.15-pr5
branch
from
6a64d1c
to
94d4845
Compare
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Feb 1, 2019
025dec0 [qa] assert_start_raises_init_error (NicolasDorier) Tree-SHA512: 0fe3ecbd47625b181aed92f15445ac26993e1a8b9843bbc1088c4adcea774e503b870912a18e13dca3f255c22a9964c1c0ca92c758907538143f316c5272ea4a
db07f91 Assert that what might look like a possible division by zero is actually unreachable (practicalswift) Tree-SHA512: f1652eb37196a5b72f356503a1fbb44fb98aa8a94954ad1765f86d81ebf41a2337d4eb58c4f19937fda3752f5d2d642756e44afdbd438015b87ac20801246bff
…rase of nonexistent "version" entry. 87ed396 [trivial] Add comment documenting bumpfee mapValues (Russell Yanofsky) a1fe944 Remove reference to nonexistent "version" wallet transaction mapvalue field (Russell Yanofsky) 654e044 [trivial] Add comment documenting CWalletTx::mapValue (Russell Yanofsky) Tree-SHA512: 1fd1860e345c59b13634db2007fff4ba30aaf1f177fdd765f47bf9257fac117cdcd5d491424416da304c08e85effbb27f3424f072f7c9587ef39cb98531b932a
PastaPastaPasta
force-pushed
the
backports-0.15-pr5
branch
from
94d4845
to
b6d59f8
Compare
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Feb 1, 2019
|
redid 9832, kept in redirect_stderr, missed a output |
PastaPastaPasta
force-pushed
the
backports-0.15-pr5
branch
from
b6d59f8
to
eadb780
Compare
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Feb 1, 2019
|
Looks good in general (merge commits match corresponding PRs as far as I can tell) but you'll need this small fix UdjinM6@3a99b3f for rpc tests to pass. (EDIT: replaced |
PastaPastaPasta
force-pushed
the
backports-0.15-pr5
branch
from
eadb780
to
071035b
Compare
UdjinM6
approved these changes
Feb 2, 2019
There was a problem hiding this comment.
utACK
(Travis failure seems to be unrelated, at least tests in a similar branch in my repo https://travis-ci.org/UdjinM6/dash/builds/487610642 are green)
|
@codablock ping :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.