Fix deadlock in CSigSharesManager::SendMessages #2757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not just set |
|
@UdjinM6 I thought ToInvStr() was more clear in the use of LLMQ_400_60, which is actually kind of a hack (we're passing the wrong type here...). |
|
True, it's hack-ish :) But the funny thing is that |
|
Yeah that's true...that was different in the past but now it's a leftover that's actually not needed. I'll remove ToInv completely now. |
Locking "cs" at this location caused a (potential) deadlock due to changed order of cs and cs_vNodes locking. This changes the method to not require the session object anymore which removes the need for locking.
codablock
force-pushed
the
pr_llmq_deadlock
branch
from
c75d534
to
2bdb856
Compare
This allows use of sizes which are not supported in chainparams.
|
Turned out that the last changes I did caused a crash due to LLMQ_400_60 not known on regtest. Changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locking "cs" at this location caused a (potential) deadlock due to changed
order of cs and cs_vNodes locking. This changes the method to not require
the session object anymore which removes the need for locking.