Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deadlock in CSigSharesManager::SendMessages #2757

Merged
merged 2 commits into from
Mar 11, 2019
Merged

Fix deadlock in CSigSharesManager::SendMessages #2757

merged 2 commits into from
Mar 11, 2019

Commits on Mar 11, 2019

  1. Fix deadlock in CSigSharesManager::SendMessages 

    Locking "cs" at this location caused a (potential) deadlock due to changed
order of cs and cs_vNodes locking. This changes the method to not require
the session object anymore which removes the need for locking.
    @codablock
    codablock committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    2bdb856 View commit details
    Browse the repository at this point in the history

  2. Pass size of LLMQ instead of llmqType into CSigSharesInv::Init 

    This allows use of sizes which are not supported in chainparams.
    @codablock
    codablock committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    5a38484 View commit details
    Browse the repository at this point in the history