Fix qt tests and actually run them #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@UdjinM6 can you re-trigger Travis so that the new build gets out of the timeout situation? |
|
I'm wondering, is there a reason why we can't change the linux64 build to not build with |
|
Hmm.. I remember we had some issues with qt back then but maybe they are solved already? Let's see what happens if we try to build with no "NO_QT=1" https://travis-ci.org/UdjinM6/dash/builds/510881067 EDIT: it succeeded 🎉 Re-enabling qt for all jobs. |
|
Re-enabled qt here, tests are green after another force-push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt tests fail when binaries are compiled with DEBUG_LOCKORDER flag. In fact we don't even run them because of
NO_QT=1in all builds withRUN_TESTS=true. This should fix both issues.