Show chainlocked txes as fully confirmed #2807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codablock
reviewed
Mar 26, 2019
| { | ||
| AssertLockHeld(cs_main); | ||
| BlockMap::iterator mi = mapBlockIndex.find(hashBlock); | ||
| if (mi != mapBlockIndex.end() && mi->second != nullptr) { |
There was a problem hiding this comment.
Just a regular safety belt. We still have quite a few places with mapBlockIndex[somehash] which can potentially insert an entry if we screw some checks up somewhere (should really get rid of these [] some day). Won't hurt to double-check imo.
There was a problem hiding this comment.
Ah ok, was already worried that I misunderstood mapBlockIndex when I used it in various places. An easy way to get rid of the [] is to use .at() as a replacement as it throws an exception when you try to access a non-existent item, instead of creating an new item as with []. Better to crash early in such cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.