Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-introduce nInstantSendKeepLock check for LLMQ-based IS when spork19 is OFF #2829

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Re-introduce nInstantSendKeepLock check for LLMQ-based IS when spork19 is OFF #2829

merged 1 commit into from
Apr 5, 2019

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Apr 4, 2019

This reuses NotifyChainLock cause effectively the same logic applies here as well.

@UdjinM6 UdjinM6 added this to the 14.0 milestone Apr 4, 2019
codablock
codablock approved these changes Apr 4, 2019
View reviewed changes
Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@codablock
Copy link

codablock commented Apr 4, 2019 •
edited
Loading

I just realized that CInstantSendManager::NotifyChainLock will cause a long hang when called the first time, as it reads all blocks until genesis. We should maybe add code to track the lowest block for which we have an InstantSend lock so that we know when to stop in NotifyChainLock.

Not related to this PR however, so another PR is needed.

@codablock codablock merged commit 208406d into dashpay:develop Apr 5, 2019
@UdjinM6 UdjinM6 deleted the clearllmqislocks branch November 26, 2020 11:36
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Mar 13, 2022
@fanquake @PastaPastaPasta
Merge bitcoin#23199: refactor: use {Read,Write}BE32 helpers for BIP…
c921d51 
…32 nChild (de)serialization

7fc487a refactor: use `{Read,Write}BE32` helpers for BIP32 nChild (de)serialization (Sebastian Falbesoner)

Pull request description:

  This small refactoring PR replaces manual bit-fiddling (de)serialization of the BIP32 child number (nChild) by the helpers `ReadBE32`/`WriteBE32`. Note that those were first introduced in dashpay#4100, almost one year _after_ the BIP32 derivation implementation has been merged (dashpay#2829, eb2c999).

ACKs for top commit:
  sipa:
    utACK 7fc487a
  laanwj:
    Code review ACK 7fc487a

Tree-SHA512: bbe3e411fb0429fa74c8a5705a91f4d6ed704dac9d6623ecb633563f22acf8e21f3189a16f1d0cf1aeedfc56a5b695df54ae51e9577e34eb6d7dc335de2da6de
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Jun 18, 2023
@fanquake @gades
Merge bitcoin#23199: refactor: use {Read,Write}BE32 helpers for BIP…
5650c64 
…32 nChild (de)serialization

7fc487a refactor: use `{Read,Write}BE32` helpers for BIP32 nChild (de)serialization (Sebastian Falbesoner)

Pull request description:

  This small refactoring PR replaces manual bit-fiddling (de)serialization of the BIP32 child number (nChild) by the helpers `ReadBE32`/`WriteBE32`. Note that those were first introduced in dashpay#4100, almost one year _after_ the BIP32 derivation implementation has been merged (dashpay#2829, eb2c999).

ACKs for top commit:
  sipa:
    utACK 7fc487a
  laanwj:
    Code review ACK 7fc487a

Tree-SHA512: bbe3e411fb0429fa74c8a5705a91f4d6ed704dac9d6623ecb633563f22acf8e21f3189a16f1d0cf1aeedfc56a5b695df54ae51e9577e34eb6d7dc335de2da6de
gades pushed a commit to piratecash/pirate that referenced this pull request Dec 9, 2023
@fanquake @gades
Merge bitcoin#23199: refactor: use {Read,Write}BE32 helpers for BIP…
411fdc5 
…32 nChild (de)serialization

7fc487a refactor: use `{Read,Write}BE32` helpers for BIP32 nChild (de)serialization (Sebastian Falbesoner)

Pull request description:

  This small refactoring PR replaces manual bit-fiddling (de)serialization of the BIP32 child number (nChild) by the helpers `ReadBE32`/`WriteBE32`. Note that those were first introduced in dashpay#4100, almost one year _after_ the BIP32 derivation implementation has been merged (dashpay#2829, eb2c999).

ACKs for top commit:
  sipa:
    utACK 7fc487a
  laanwj:
    Code review ACK 7fc487a

Tree-SHA512: bbe3e411fb0429fa74c8a5705a91f4d6ed704dac9d6623ecb633563f22acf8e21f3189a16f1d0cf1aeedfc56a5b695df54ae51e9577e34eb6d7dc335de2da6de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codablock codablock codablock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@UdjinM6 @codablock