Skip required services and port checks when outgoing connections is a MN #2847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just realized (by looking at Travis failures) that this depends on #2848 🙈 I'll rebase this PR after it is merged. |
codablock
force-pushed
the
pr_llmq_allow_different_port
branch
from
8265227
to
f22b0dd
Compare
|
Rebased on develop to fix the dependency on #2848 |
Co-Authored-By: codablock <ablock84@gmail.com>
UdjinM6
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue seen on testnet where the connection loop avoids connecting to nodes with non-default ports. It is however well known that masternodes on testnet are using non-default ports, which leads to many/most masternodes not being considered for outgoing connections.
This PR fixes this by making an exception to this check when the address is known to be from a masternode. It also adds an exception to the required services check just in case we ever add services which are only announced by masternodes.