Connect to most recently updated address in ThreadOpenMasternodeConnections #2848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions It's not a good idea to try to connect to an old address of a masternode. This will also skip connection attempts when the masternode is not in the valid set anymore (banned or collateral spent).
Not needed anymore as we retrieve the service/address of a masternode on-the-fly in ThreadOpenMasternodeConnections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where intra quorum connections from older LLMQs are tried on stale addresses. When a MNO issues
update_serviceand changes the IP:port, we should connect to the updated IP:port even if the LLMQ internally uses older versions of the DMN object/state.This also avoids connecting to masternodes which are not in the valid set anymore (banned or spent collateral).