Archive islock hashes when removing confirmed islocks #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows AlreadyHave to check if an announced (via INV) islock was already known in the past. This avoids requesting islocks which got obsolete due to ChainLocks.
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 14, 2021
…ew class 5fa28e9 refactor: Remove unused signal (Hennadii Stepanov) Pull request description: `WalletView::showNormalIfMinimized()` signal was introduced in dashpay#2872 (dbc0a6a). The only signal emit command was removed in dashpay#3144 (2384a28) ACKs for top commit: promag: ACK 5fa28e9. practicalswift: ACK 5fa28e9: nice find emilengler: ACK 5fa28e9 jonasschnelli: utACK 5fa28e9 Tree-SHA512: 4714acf8c683594d3c00523c7b14bc6b94d469418f0cebe4f4b5266ca0e4c45c80d4caf358739eae9231ee4a69c9c902caeb35f3866b99443cf653f89d6d825b
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 14, 2021
…ew class 5fa28e9 refactor: Remove unused signal (Hennadii Stepanov) Pull request description: `WalletView::showNormalIfMinimized()` signal was introduced in dashpay#2872 (dbc0a6a). The only signal emit command was removed in dashpay#3144 (2384a28) ACKs for top commit: promag: ACK 5fa28e9. practicalswift: ACK 5fa28e9: nice find emilengler: ACK 5fa28e9 jonasschnelli: utACK 5fa28e9 Tree-SHA512: 4714acf8c683594d3c00523c7b14bc6b94d469418f0cebe4f4b5266ca0e4c45c80d4caf358739eae9231ee4a69c9c902caeb35f3866b99443cf653f89d6d825b
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 15, 2021
…ew class 5fa28e9 refactor: Remove unused signal (Hennadii Stepanov) Pull request description: `WalletView::showNormalIfMinimized()` signal was introduced in dashpay#2872 (dbc0a6a). The only signal emit command was removed in dashpay#3144 (2384a28) ACKs for top commit: promag: ACK 5fa28e9. practicalswift: ACK 5fa28e9: nice find emilengler: ACK 5fa28e9 jonasschnelli: utACK 5fa28e9 Tree-SHA512: 4714acf8c683594d3c00523c7b14bc6b94d469418f0cebe4f4b5266ca0e4c45c80d4caf358739eae9231ee4a69c9c902caeb35f3866b99443cf653f89d6d825b
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Nov 30, 2023
…ew class 5fa28e9 refactor: Remove unused signal (Hennadii Stepanov) Pull request description: `WalletView::showNormalIfMinimized()` signal was introduced in dashpay#2872 (dbc0a6a). The only signal emit command was removed in dashpay#3144 (2384a28) ACKs for top commit: promag: ACK 5fa28e9. practicalswift: ACK 5fa28e9: nice find emilengler: ACK 5fa28e9 jonasschnelli: utACK 5fa28e9 Tree-SHA512: 4714acf8c683594d3c00523c7b14bc6b94d469418f0cebe4f4b5266ca0e4c45c80d4caf358739eae9231ee4a69c9c902caeb35f3866b99443cf653f89d6d825b
gades
pushed a commit
to piratecash/pirate
that referenced
this pull request
Dec 9, 2023
…ew class 5fa28e9 refactor: Remove unused signal (Hennadii Stepanov) Pull request description: `WalletView::showNormalIfMinimized()` signal was introduced in dashpay#2872 (dbc0a6a). The only signal emit command was removed in dashpay#3144 (2384a28) ACKs for top commit: promag: ACK 5fa28e9. practicalswift: ACK 5fa28e9: nice find emilengler: ACK 5fa28e9 jonasschnelli: utACK 5fa28e9 Tree-SHA512: 4714acf8c683594d3c00523c7b14bc6b94d469418f0cebe4f4b5266ca0e4c45c80d4caf358739eae9231ee4a69c9c902caeb35f3866b99443cf653f89d6d825b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows AlreadyHave to check if an announced (via INV) islock was
already known in the past. This avoids requesting islocks which got
obsolete due to ChainLocks.