Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor sporks to get rid of repeated if/else blocks #2946

Merged
merged 5 commits into from
May 29, 2019
Merged

Refactor sporks to get rid of repeated if/else blocks #2946

merged 5 commits into from
May 29, 2019

Commits on May 29, 2019

  1. Use enum to define spork IDs

    @codablock
    codablock committed May 29, 2019
    Configuration menu
    Copy the full SHA
    78414a1 View commit details
    Browse the repository at this point in the history

  2. Introduce CSporkDef and remove if/else blocks in GetSporkIDByName/Get… 

    …SporkNameByID
    @codablock
    codablock committed May 29, 2019
    Configuration menu
    Copy the full SHA
    5713162 View commit details
    Browse the repository at this point in the history

  3. Deduplicate code in IsSporkActive

    @codablock
    codablock committed May 29, 2019
    Configuration menu
    Copy the full SHA
    0cb0840 View commit details
    Browse the repository at this point in the history

  4. Fix spork RPC to use new spork defs 

    This also removes the need for SPORK_START/SPORK_END
    @codablock
    codablock committed May 29, 2019
    Configuration menu
    Copy the full SHA
    9756cb6 View commit details
    Browse the repository at this point in the history

  5. Move sporkManager global variable below sporkDefs 

    This ensures correct order of initialization.
    @codablock
    codablock committed May 29, 2019
    Configuration menu
    Copy the full SHA
    5ac21fa View commit details
    Browse the repository at this point in the history