Also handle/resolve orphan TXs when parents appear in a block #3139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codablock
changed the title
|
utACK to merge after rebase |
UdjinM6
reviewed
Oct 4, 2019
This makes orphan processing work like handling getdata messages: After every actual transaction validation attempt, interrupt processing to deal with messages arriving from other peers.
codablock
force-pushed
the
pr_orphanhandling
branch
from
1feb863
to
9a06702
Compare
|
rebased on develop |
| @@ -853,7 +853,7 @@ void PeerLogicValidation::BlockConnected(const std::shared_ptr<const CBlock>& pb | |||
| for (const CTransactionRef& ptx : pblock->vtx) { | |||
| const CTransaction& tx = *ptx; | |||
|
|
|||
| // Can we accept new orphan entries? | |||
| // Which orphan pool entries we should reprocess and potentially try to accept into mempool again? | |||
There was a problem hiding this comment.
can you squash this commit in af7124e?
codablock
force-pushed
the
pr_orphanhandling
branch
from
9a06702
to
a12b03e
Compare
PastaPastaPasta
approved these changes
Oct 7, 2019
|
@codablock Ah, ok 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix many of the mempool inconsistencies seen on mainnet when high load appears with many chained transactions.
This also backports bitcoin#15644 as we need the orphan handling to be callable from outside of ProcessMessage.
The PR is currently built on top of #3127 as it adds more testing to orphan TX handling.