-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Rebranding: Darksend/InstantX changed to PrivateSend/InstantSend (UI+log) #760
Conversation
Thanks for looking into this! However, now with that done in code it looks like this DS->PP transition is not going to be that easy to implement and it looks messy tbh (imo)... Maybe it would be a better idea to get rid of any technology name at all in UI/logs/rpc(?) and replace it with smth more general like simply "mixing", "mixed", "private" etc. And few side notes:
|
@UdjinM6 I think the main problem is the mixing button, I think I'll change it to "Start Mixing" and be done with it. And, yes, I meant exactly those protocol messages. (on the other hand, we live in a "Design-Driven" world, so I wouldn't be TOO surprised if one day someone somewhere on this planet changes a protocol because the protocol-messages need a re-branding. |
@UdjinM6 @schinzelh : somewhere during the last big Bitcoin-merge parts of #612 got lost (here: no theme-dependent splash-screens). However, some things are still not there, e.g. the theme-dependent tx_input/tx_inout/tx_whatever icons (they show up fine on the 'Transactions' page, but the bigger ones on the 'Overview' page are gone). The resources are all there, though. I don't have any local working repositories of my changes any more, so I can't easily diff through the files. Something seems to be changed in TransactionTableModel but I cannot find what..I guess it's just TOO obvious to be found by myself :-/ |
b61849c is a step in the right direction ;) I guess tungfa already sent you an image with few more changes so we all should be on the same page now. Re issues with splash screen: |
@evan82 @schinzelh , it's ready to merge now, from the UI and log point of view Darksend is PrivateSend now and InstantX is InstantSend. |
Update: ------------------------------------------------------------------------
After some discussions there seems to be consensus that "Darksend" will be re-branded to "PrivateSend" and "InstantX" to "InstantSend".
Reasoning: PrivateSend gets us away from our dark side :-), and InstantSend is less technical and better to understand for 'normal' people.
Whatever 'normal' is 😜
References:
Discussion: https://www.dash.org/forum/threads/darksend-rebranding-discussion.8710/
Someone created a poll: https://www.dash.org/forum/threads/non-binding-wallet-terms-vote.8715/
End of Update -----------------------------------------------------------------
tungfa told me that "Darksend" will be re-branded to "PrivacyProtect". This is a first result.
Please test and report back if I missed some occurrences.
What's covered:
What's not covered:
I can do 1. and 2. later if wanted, 3. + 4. is for someone who REALLY is bored :-)
Overview-screen looks like this now: