Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DIP6] Add llmqTypes details to qfcommit #37

Merged
merged 3 commits into from Dec 27, 2018
Merged

[DIP6] Add llmqTypes details to qfcommit #37

merged 3 commits into from Dec 27, 2018

Conversation

thephez
Copy link
Collaborator

@thephez thephez commented Dec 18, 2018 •
edited

Aligns the DIP with the Dash Core implementation details referenced in the issue.
Closes #36

nmarley
nmarley previously approved these changes Dec 19, 2018
View reviewed changes
Copy link
Collaborator

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, assuming this will need to go in (doesn't make sense to omit this IMO)

codablock
codablock reviewed Dec 27, 2018
View reviewed changes
dip-0006.md Outdated Show resolved Hide resolved
codablock
codablock approved these changes Dec 27, 2018
View reviewed changes
Copy link
Contributor

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@thephez thephez merged commit 6774348 into master Dec 27, 2018
@thephez thephez deleted the pr_dip6_llmqtype branch December 27, 2018 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codablock codablock codablock approved these changes

@nmarley nmarley nmarley left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thephez @nmarley @codablock