Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashmate): http API calls fail with command not found error #1600

Merged
merged 13 commits into from
Dec 4, 2023
Merged

fix(dashmate): http API calls fail with command not found error #1600

merged 13 commits into from
Dec 4, 2023

Conversation

pshenmic
Copy link
Collaborator

@pshenmic pshenmic commented Nov 24, 2023 •
edited
Loading

Issue being fixed or feature implemented

Dashmate helper API is not working due legacy api command invocation

What was done?

  • Migrated helper oclif run command to ESM (await import)
  • Added a E2E test for Dashmate Helper (ensures HTTP API is able to respond)

How Has This Been Tested?

Locally with local network

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pshenmic pshenmic added this to the v0.25.x milestone Nov 24, 2023
@pshenmic pshenmic self-assigned this Nov 24, 2023
shumkov
shumkov previously approved these changes Nov 24, 2023
View reviewed changes
@pshenmic pshenmic changed the base branch from v1.0-dev to master November 24, 2023 14:39
@shumkov shumkov changed the title fix(dashmate): migrate helper oclif invocation fix(dashmate): API calls fail Nov 29, 2023
@shumkov shumkov changed the title fix(dashmate): API calls fail fix(dashmate): API calls fail with command not found error Nov 29, 2023
@pshenmic pshenmic changed the title fix(dashmate): API calls fail with command not found error fix(dashmate): api calls fail with command not found error Nov 29, 2023
@pshenmic pshenmic changed the title fix(dashmate): api calls fail with command not found error fix(dashmate): helper HTTP API calls fail with command not found error Nov 29, 2023
@pshenmic pshenmic changed the title fix(dashmate): helper HTTP API calls fail with command not found error fix(dashmate): helper HTTP API calls fail with command not found error Nov 29, 2023
@shumkov shumkov changed the title fix(dashmate): helper HTTP API calls fail with command not found error fix(dashmate): HTTP API calls fail with command not found error Dec 4, 2023
shumkov
shumkov approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@shumkov shumkov changed the title fix(dashmate): HTTP API calls fail with command not found error fix(dashmate): http API calls fail with command not found error Dec 4, 2023
@shumkov shumkov merged commit d175bda into master Dec 4, 2023
22 of 23 checks passed
@shumkov shumkov deleted the fix/dashmate-helper branch December 4, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer QuantumExplorer is a code owner

Assignees

@pshenmic pshenmic

Labels
None yet
Projects
None yet
Milestone
v0.25.x
Development

Successfully merging this pull request may close these issues.
2 participants
@pshenmic @shumkov