-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dashmate): remove unnecessary WASM DPP #1607
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshenmic
requested review from
shumkov,
antouhou and
QuantumExplorer
as code owners
November 29, 2023 05:02
shumkov
requested changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't use it why not just removed it from dependencies?
shumkov
requested changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasm-dpp is still using in feature flag command. You probably should remove it
This reverts commit 1d51f34.
shumkov
changed the title
fix(dashmate): disable WASM-DPP initialization
chore(dashmate): remove unnecessary WASM DPP
Dec 5, 2023
shumkov
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Dashmate load up and init WASM DPP on every command run, but in fact, it is only used in one place, where latest appVersion being extracted and set in local setup.
This causes cross-platform issues on some specific CPUs, more details could be read here #1583
This PR removes initialization of WASM DPP in the dashmate
What was done?
platform.drive.tenderdash.genesis.consensus_params.version.app_version
config set duringconfigureTenderdashTaskFactory.js
, because it is always1
How Has This Been Tested?
CI
Breaking Changes
No
Checklist:
For repository code-owners and collaborators only