Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashmate): remove unnecessary WASM DPP #1607

Merged
merged 14 commits into from
Dec 5, 2023

Conversation

pshenmic
Copy link
Collaborator

Issue being fixed or feature implemented

Dashmate load up and init WASM DPP on every command run, but in fact, it is only used in one place, where latest appVersion being extracted and set in local setup.

This causes cross-platform issues on some specific CPUs, more details could be read here #1583

This PR removes initialization of WASM DPP in the dashmate

What was done?

  • Removed initlization of Wasm DPP
  • Removed redundant platform.drive.tenderdash.genesis.consensus_params.version.app_version config set during configureTenderdashTaskFactory.js, because it is always 1

How Has This Been Tested?

CI

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't use it why not just removed it from dependencies?

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasm-dpp is still using in feature flag command. You probably should remove it

@shumkov shumkov changed the title fix(dashmate): disable WASM-DPP initialization chore(dashmate): remove unnecessary WASM DPP Dec 5, 2023
@shumkov shumkov merged commit c0140e7 into master Dec 5, 2023
22 checks passed
@shumkov shumkov deleted the feat/dashmate-disable-wasm-init branch December 5, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants