Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashmate): limit concurrent state transition checks #1824

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Apr 20, 2024

Issue being fixed or feature implemented

To protect Drive from overwhelming number of check tx ABCI calls in case of stress testing or an attack, we need limit max concurrent check tx calls in Tenderdash dashpay/tenderdash#775

What was done?

  • Update tenderdash to a version that supports check tx concurrency limiting
  • Add platform.drive.tenderdash.mempool.maxConcurrentCheckTx option to dashmate

How Has This Been Tested?

Broadcasting transactions to local network

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the title chore(dashmate): limit concurrent state transition pre-validations chore(dashmate): limit concurrent state transition pre-validation Apr 20, 2024
@shumkov shumkov changed the title chore(dashmate): limit concurrent state transition pre-validation chore(dashmate): limit concurrent state transition check Apr 20, 2024
@shumkov shumkov changed the title chore(dashmate): limit concurrent state transition check chore(dashmate): limit concurrent state transition checks Apr 20, 2024
@shumkov shumkov added this to the v1.0.0 milestone Apr 22, 2024
@shumkov shumkov marked this pull request as ready for review April 22, 2024 00:53
lklimek
lklimek previously approved these changes Apr 22, 2024
packages/dashmate/configs/defaults/getBaseConfigFactory.js Outdated Show resolved Hide resolved
lklimek
lklimek previously approved these changes Apr 22, 2024
@shumkov shumkov merged commit 2a331c1 into v1.0-dev Apr 26, 2024
21 checks passed
@shumkov shumkov deleted the chore/limit-check-tx branch April 26, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants