feat(platform)!: total credits on platform query and fix for reward distribution #2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldelucia
previously approved these changes
Aug 2, 2024
…/platform into feat/totalCreditsOnPlatformQuery
QuantumExplorer
changed the title
shumkov
previously approved these changes
Aug 13, 2024
| @@ -109,6 +82,15 @@ pub struct CoreConfig { | |||
| pub check_tx_rpc: CheckTxCoreRpcConfig, | |||
| } | |||
|
|
|||
| impl Default for CoreConfig { | |||
There was a problem hiding this comment.
Minor: this impl can be derived
| use lazy_static::lazy_static; | ||
| use std::collections::HashMap; | ||
|
|
||
| lazy_static! { |
There was a problem hiding this comment.
Minor: preferable to use LazyCell
| @@ -38,10 +40,21 @@ impl<C> Platform<C> { | |||
| return Ok(None); | |||
| }; | |||
|
|
|||
| let start_block_core_height = if unpaid_epoch.epoch_index == 0 { | |||
There was a problem hiding this comment.
Minor: use constant GENESIS_EPOCH
shumkov
previously approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
While we could ask Platform for the total number of credits in Platform, this was not taking into consideration promised rewards due to the core block height increase.
What was done?
Created a new query that will get the total number of credits in Platform, but also the current unpaid epoch and it's start block height. With all this information we can calculate the total credits in Platform with rewards taken into account. Something that should match what Core has (except if there are identity funding state transactions that have not been used).
How Has This Been Tested?
Added a few tests to make sure this was working.
Breaking Changes
This is not a breaking change.
Checklist:
For repository code-owners and collaborators only