Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform)!: store/fetch genesis core height in misc tree #2038

Merged
merged 7 commits into from
Aug 7, 2024

Conversation

ogabrielides
Copy link
Contributor

@ogabrielides ogabrielides commented Aug 6, 2024

Issue being fixed or feature implemented

Platform needs to know the genesis core height for correct credit pool calculations.

What was done?

Added fetch and store methods for the genesis core height in misc tree of groveDB.

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@ogabrielides ogabrielides changed the title feat: store genesis core height in misc feat: store genesis core height in misc tree Aug 6, 2024
@ogabrielides ogabrielides changed the title feat: store genesis core height in misc tree feat: store/fetch genesis core height in misc tree Aug 6, 2024
QuantumExplorer
QuantumExplorer previously approved these changes Aug 7, 2024
@QuantumExplorer QuantumExplorer changed the base branch from v1.0-dev to v1.1-dev August 7, 2024 04:52
@QuantumExplorer QuantumExplorer dismissed their stale review August 7, 2024 04:52

The base branch was changed.

@QuantumExplorer QuantumExplorer changed the title feat: store/fetch genesis core height in misc tree feat(platform)!: store/fetch genesis core height in misc tree Aug 7, 2024
@QuantumExplorer QuantumExplorer merged commit 4c56692 into v1.1-dev Aug 7, 2024
36 of 37 checks passed
@QuantumExplorer QuantumExplorer deleted the genesis_in_platform_state branch August 7, 2024 05:41
@thephez thephez added this to the v1.1.0 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants