Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure wait for ST result timeout #2045

Merged
merged 6 commits into from
Aug 13, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Aug 12, 2024

Issue being fixed or feature implemented

Client is failing to get ST execution results due to timeouts on bigger network. To be able to tune the timeout we need to make it configurable.

What was done?

  • Add an env to DAPI to configure the timeout
  • Add an option to Dashmate to configure timeout
  • Update timeouts to 120s

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v1.1 milestone Aug 12, 2024
@@ -135,13 +135,13 @@
path: "/org.dash.platform.dapi.v0.Platform/waitForStateTransitionResult"
route:
cluster: dapi_api
idle_timeout: 85s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think timeout on envoy level should be slightly higher that the one SDK/DAPI uses.

This way, if a timeout error happens inside DAPI, Envoy will still have time to correctly forward it to the client. Otherwise, client will get Envoy timeout instead of DAPI-generated one.

lklimek
lklimek previously approved these changes Aug 13, 2024
@shumkov shumkov merged commit 38fa81b into v1.1-dev Aug 13, 2024
10 checks passed
@shumkov shumkov deleted the feat/configure-wait-for-st-result-timeout branch August 13, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants