Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dpp): function for getting enabled matching public keys in identities #2052

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

pauldelucia
Copy link
Member

Issue being fixed or feature implemented

We had a function to get the first public key for an identity matching certain parameters but it wouldn't check if the keys were disabled. I added a function that checks that they're enabled as well. Maybe we just want to replace the previous function with the new function?

What was done?

Add new function to IdentityV0Getters

How Has This Been Tested?

TUI

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer changed the title feat: function for getting enabled matching public keys in identities feat(dpp): function for getting enabled matching public keys in identities Aug 20, 2024
@QuantumExplorer QuantumExplorer merged commit 00f0b6a into v1.1-dev Aug 20, 2024
64 checks passed
@QuantumExplorer QuantumExplorer deleted the feat/get-enabled-public-keys branch August 20, 2024 12:15
@thephez thephez added this to the v1.1.0 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants