Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashmate): configure proposer and tx limits #2057

Merged
merged 4 commits into from
Aug 21, 2024
Merged

feat(dashmate): configure proposer and tx limits #2057

merged 4 commits into from
Aug 21, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Aug 14, 2024 •
edited
Loading

Issue being fixed or feature implemented

We should be able to configure proposer tx processing time and mempool tx limits

What was done?

  • Added platform.drive.abci.proposer.txProcessingTimeLimit
  • Added platform.drive.tenderdash.mempool.ttlDuration
  • Added platform.drive.tenderdash.mempool.ttlNumBlocks
  • Made proposer tx processing time limit optional

How Has This Been Tested?

Locally

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v1.1.0 milestone Aug 14, 2024
pshenmic
pshenmic previously approved these changes Aug 14, 2024
View reviewed changes
ogabrielides
ogabrielides previously approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit 4f32c35 into v1.1-dev Aug 21, 2024
27 checks passed
@shumkov shumkov deleted the feat/dashmate/proposer-and-tx-limits branch August 21, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielides ogabrielides ogabrielides approved these changes

@QuantumExplorer QuantumExplorer QuantumExplorer approved these changes

@pshenmic pshenmic pshenmic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shumkov @ogabrielides @QuantumExplorer @pshenmic