Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk)!: mock sdk cannot find quorum keys in offline mode #2061

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

lklimek
Copy link
Contributor

@lklimek lklimek commented Aug 16, 2024

Issue being fixed or feature implemented

In some circumstances, mocking subsystem fails to load public keys from test vectors directory.

What was done?

Mock SDK uses "main" Sdk object's MockContextProvider to fetch quorum info.
Fixed configuration of MockContextProvider and mock sdk to autoload vectors on start.

How Has This Been Tested?

Using GHA

Breaking Changes

It is no longer needed to load test vectors or quorum keys, as they are automatically loaded from the dump_dir during SdkBuilder::build().

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer merged commit 1ba00e0 into v1.1-dev Aug 20, 2024
23 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/sdk-mock-no-quorum-keys branch August 20, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants