-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(drive)!: just in time fee update fixes #2075
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
requested changes
Aug 24, 2024
Some CI flakiness, but everything is really passing. Merging in. |
post-merging approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strategy test
run_chain_insert_many_new_identity_per_block_many_document_insertions_updates_and_deletions_with_epoch_change panickes with integer overflow when executed with 70+ blocks (default was 30: explanation why test isn't failing).
Function combine_non_base_epoch_bytes for each epoch was adding up the same value resulting into a geometrical growth of added_bytes.
combine_non_base_epoch_bytes: self:{2: 31} & rhs:{2: 31} -> {2: 62}
combine_non_base_epoch_bytes: self:{2: 62} & rhs:{2: 62} -> {2: 124}
...
What was done?
combine_non_base_epoch_bytes was updated to keep the value of bytes from rhs epoch_index_map for each corresponding epoch instead.
Updated behavior:
combine_non_base_epoch_bytes: self:{2: 21} & rhs:{2: 21} -> {2: 21}
Moved storage flags to GroveDB.
Fixed logic of splitting refunds.
How Has This Been Tested?
A lot of tests were added.
Breaking Changes
This is a breaking fix.
Checklist:
For repository code-owners and collaborators only