Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: identity public key purpose and security levels #46

Merged
merged 31 commits into from
Dec 1, 2021

Conversation

antouhou
Copy link
Collaborator

Issue being fixed or feature implemented

Identity multikeys as per DIP-11: https://github.com/dashpay/dips/blob/master/dip-0011.md#keys

What was done?

  • Add purpose and securityLevel fields to public keys
  • Change identity facade to accept raw public key objects instead of public key data
  • Add three enums with purposes, security levels and allowed combinations of them
  • Changed public key validation function to check that the security level is in the allowed range for a specific key purpose
  • Updated fixtures to include all the changes

How Has This Been Tested?

Run the tests, add some new tests

Breaking Changes

dpp.identity.create now accepts a raw public key object instead of just public key data blob

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@antouhou antouhou added this to the v0.22.0 milestone Nov 18, 2021
@antouhou antouhou marked this pull request as ready for review November 26, 2021 08:41
# Conflicts:
#	package.json
@shumkov shumkov changed the title feat!: identity multikeys feat!: identity public key purpose and security levels Dec 1, 2021
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@antouhou antouhou merged commit 511a375 into v0.22-dev Dec 1, 2021
@antouhou antouhou deleted the feat-keys branch December 1, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants