build(dapi-grpc): update grpc protoc image #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* migrated DockerCompose build command to observable
shumkov
changed the title
shumkov
changed the title
|
I needed #541 in order to develop and test this, so I think I need to rebase this after #541 is merged so the right commits appear? It wasn't possible to merge it first because GitHub was still rolling out the bugfix, but I wanted to continue work on updating this component. @nmarley maybe something interesting to include in git training? |
markin-io
pushed a commit
that referenced
this pull request
Nov 25, 2022
* chore: remove temporary buildx bake fix * chore: remove code that depends on a process being returned * chore: clean up unused vars * feat(dashmate): pipe build output to task output * migrated DockerCompose build command to observable * debug: ci * chore: bump buildx version * chore: remove custom protoc images and revert to upstream * debug: dump env to check compose vars * chore: remove deprecated env * fix: pull access denied * fix: action `uses` syntax * fix: correct repo name * chore: clean up debug * chore: remove debug * fix: linter errors * fix: compose 2.11.x build error * chore: simplify grpc build * chore: remove task to force compose version * chore: only pipe stdout if verbose * fix: move conditional inside observer Co-authored-by: pshenmic <pshenmic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
We are depending on two unmaintained Docker images to build grpc:
strophy/grpc-web-commonstrophy/protocWe can reduce this to one image, which will make the build faster, simpler and more consistent
What was done?
I've been working with the upstream project to fix packaging problems and add arm support. This build precedes a functioning release from upstream, when we can stop depending on
strophynamespaced imagesHow Has This Been Tested?
Locally and in CI
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only