fix(wallet-lib): eventemitter memory leak

[markin-io]

Issue being fixed or feature implemented

The wallet was hooking on lots of redundant event listeners during the processing raw transactions from the stream.

What was done?

Remove event listeners right after they'd became not needed

How Has This Been Tested?

• Manually broadcast 10 transactions one by one to ensure that the warning does not appear anymore
• Ensure that the warning is not present in the logs of the test suites

Breaking Changes

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

[shumkov]

Interesting why this one doesn't work https://github.com/dashevo/platform/blob/7d55efa825d6b89f3c101c856d2253ef9a551e7a/packages/wallet-lib/src/transport/AbstractTransport.js#L15 Do we still need it?

[markin-io]

@shumkov this one is attached to the DAPIClientTransport. I guess it needs to be there.
The one I worked with comes from the class Account extends EventEmitter.

[shumkov]

@markin-io We've added that one actually to solve the same thing. Maybe mistakenly? Should we remove it?

Also, you solution doesn't create new listeners for the same transactions. But you'll get warning if you will have more than 11 transaction to get in the block, right?

[markin-io]

@shumkov after the removal of the setMaxListeners(0) I couldn't see any difference, so there is a chance that it could've been added by mistake.

As of the warning for more than 11 transactions, this is true. I will think of some kind of a queue to solve this.

[shumkov]

Good catch! 👍