Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dpp): existing property in a new index #694

Merged
merged 7 commits into from
Jan 23, 2023
Merged

fix(dpp): existing property in a new index #694

merged 7 commits into from
Jan 23, 2023

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Dec 22, 2022 •
edited by shuplenkov
Loading

Issue being fixed or feature implemented

validateIndicesAreBackwardCompatible function should not allow using existing property in a new index

What was done?

Fixed a bug in validateIndicesAreBackwardCompatible function

How Has This Been Tested?

With tests

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.24.0 milestone Jan 17, 2023
@shuplenkov shuplenkov marked this pull request as ready for review January 17, 2023 16:52
Konstantin Shuplenkov added 4 commits January 18, 2023 14:35
@shumkov shumkov merged commit cf30d97 into v0.24-dev Jan 23, 2023
@shumkov shumkov deleted the validate-existing-field-new-index branch January 23, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuplenkov shuplenkov shuplenkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shumkov @shuplenkov