Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashmate): make dashmate helper run commands as host user #765

Merged
merged 8 commits into from
Feb 20, 2023

Conversation

pshenmic
Copy link
Collaborator

@pshenmic pshenmic commented Feb 1, 2023

Issue being fixed or feature implemented

dashmate-helper container is being run as root user, and when you try to execute commands from inside the container, it re-renders the configuration with the root:root owner. This PR passes host user and group ids for dashmate-helper container

What was done?

Made dashmate grab the current executing user uid and gid and pass it to the docker compose, allowing to execute docker commands inside container without any issues

How Has This Been Tested?

On the devnet via dash-network-deploy tool

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pshenmic pshenmic marked this pull request as draft February 1, 2023 09:53
@pshenmic pshenmic self-assigned this Feb 17, 2023
@pshenmic pshenmic added this to the v0.24.0 milestone Feb 17, 2023
@pshenmic pshenmic added dashmate Dashmate related and removed dashmate Dashmate related labels Feb 17, 2023
@pshenmic pshenmic marked this pull request as ready for review February 17, 2023 15:08
@shumkov
Copy link
Member

shumkov commented Feb 18, 2023

@pshenmic PR title should represent the problem what you fixing, but not how you fixing. It's important to make changelog's "Bugfixes" section understandable.

@pshenmic pshenmic changed the title fix(dashmate): use host user inside dashmate-helper container fix(dashmate): make dashmate helper run commands as host user Feb 18, 2023
@shumkov shumkov merged commit 36eeaac into v0.24-dev Feb 20, 2023
@shumkov shumkov deleted the fix/dashmate-helper-perms branch February 20, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants