Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: chainlock quorum rotation test #952

Merged
merged 4 commits into from
Apr 21, 2023

Conversation

QuantumExplorer
Copy link
Member

Issue being fixed or feature implemented

What was done?

There are 3 tests:

  • one for when quorums rotate because of core chain lock height going up.
  • one for when hpmns come in.
  • one for when hpmns are removed.

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@@ -8,7 +8,7 @@ authors = ["Anton Suprunchuk <anton.suprunchuk@gmail.com>"]
anyhow = { version = "1.0.70" }
async-trait = { version = "0.1" }
base64 = "0.20.0"
bls-signatures = { git = "https://github.com/dashpay/bls-signatures", branch = "feat/threshold_bindings_working" }
bls-signatures = { git = "https://github.com/dashpay/bls-signatures", branch = "feat/clone" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we create a tag that will point to currently "best" version for 0.25? Like platform-0.25 ?

It's a mess atm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well... clone is basically the renamed feat/threshold_bindings_working

@QuantumExplorer QuantumExplorer merged commit 2bf9081 into v0.25-dev Apr 21, 2023
@QuantumExplorer QuantumExplorer deleted the test/chainlockquorumrotationtest branch April 21, 2023 09:07
@thephez thephez added this to the v0.25.0 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants