Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet-lib)!: connects to modified storage #232

Merged
merged 31 commits into from
Mar 8, 2022

Conversation

Alex-Werner
Copy link
Contributor

Issue being fixed or feature implemented

In dashevo/wallet-lib#351, we introduced multiple features that couldn't be managed as is due to their size.
This PR connects with the previous PR and does modify deeply wallet-lib.
Built on top of #231

What was done?

TODO

How Has This Been Tested?

TODO

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • [] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Alex-Werner Alex-Werner changed the base branch from v0.22-dev to v0.23-dev February 14, 2022 19:39
@lgtm-com
Copy link

lgtm-com bot commented Feb 15, 2022

This pull request introduces 2 alerts when merging 03e4f6e into 778bfce - view on LGTM.com

new alerts:

  • 2 for Ineffective parameter type

@lgtm-com
Copy link

lgtm-com bot commented Feb 15, 2022

This pull request introduces 2 alerts when merging 578a1c4 into 778bfce - view on LGTM.com

new alerts:

  • 2 for Ineffective parameter type

@lgtm-com
Copy link

lgtm-com bot commented Feb 16, 2022

This pull request introduces 2 alerts when merging 936aa16 into 26c0486 - view on LGTM.com

new alerts:

  • 2 for Ineffective parameter type

@lgtm-com
Copy link

lgtm-com bot commented Feb 16, 2022

This pull request introduces 2 alerts when merging 8218a50 into 26c0486 - view on LGTM.com

new alerts:

  • 2 for Ineffective parameter type

@lgtm-com
Copy link

lgtm-com bot commented Feb 16, 2022

This pull request introduces 2 alerts when merging df6851d into 26c0486 - view on LGTM.com

new alerts:

  • 2 for Ineffective parameter type

@lgtm-com
Copy link

lgtm-com bot commented Feb 17, 2022

This pull request introduces 2 alerts when merging d377e61 into 26c0486 - view on LGTM.com

new alerts:

  • 2 for Ineffective parameter type

@lgtm-com
Copy link

lgtm-com bot commented Feb 17, 2022

This pull request introduces 2 alerts when merging 6752a48 into 26c0486 - view on LGTM.com

new alerts:

  • 2 for Ineffective parameter type

@lgtm-com
Copy link

lgtm-com bot commented Feb 17, 2022

This pull request introduces 2 alerts when merging bfa30d5 into 26c0486 - view on LGTM.com

new alerts:

  • 2 for Ineffective parameter type

@lgtm-com
Copy link

lgtm-com bot commented Feb 20, 2022

This pull request introduces 2 alerts when merging 7d5c276 into 26c0486 - view on LGTM.com

new alerts:

  • 2 for Ineffective parameter type

@lgtm-com
Copy link

lgtm-com bot commented Feb 20, 2022

This pull request introduces 2 alerts when merging 3f8c683 into 26c0486 - view on LGTM.com

new alerts:

  • 2 for Ineffective parameter type

@lgtm-com
Copy link

lgtm-com bot commented Feb 28, 2022

This pull request introduces 2 alerts when merging 5c81461 into 26c0486 - view on LGTM.com

new alerts:

  • 2 for Ineffective parameter type

@lgtm-com
Copy link

lgtm-com bot commented Mar 1, 2022

This pull request introduces 2 alerts when merging eb6ee75 into 26c0486 - view on LGTM.com

new alerts:

  • 2 for Ineffective parameter type

@lgtm-com
Copy link

lgtm-com bot commented Mar 1, 2022

This pull request introduces 2 alerts when merging 3ba7213 into 26c0486 - view on LGTM.com

new alerts:

  • 2 for Ineffective parameter type

@lgtm-com
Copy link

lgtm-com bot commented Mar 8, 2022

This pull request introduces 2 alerts when merging 9f528c5 into a6acd1a - view on LGTM.com

new alerts:

  • 2 for Ineffective parameter type

@lgtm-com
Copy link

lgtm-com bot commented Mar 8, 2022

This pull request introduces 2 alerts when merging cc6773b into a6acd1a - view on LGTM.com

new alerts:

  • 2 for Ineffective parameter type

@markin-io markin-io changed the title feat: connects to modified storage feat(wallet-lib)!: connects to modified storage Mar 8, 2022
Copy link
Contributor

@markin-io markin-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@markin-io markin-io merged commit 2643791 into v0.23-dev Mar 8, 2022
@markin-io markin-io deleted the feat/improved-storage branch March 8, 2022 15:09
@thephez thephez added this to the v0.23.0 milestone Mar 15, 2022
markin-io added a commit that referenced this pull request Apr 25, 2022
Co-authored-by: Igor Markin <igor.markin@dash.org>
markin-io added a commit that referenced this pull request Apr 27, 2022
Co-authored-by: Igor Markin <igor.markin@dash.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants