Move dask.async to dask.local #2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 3.7 `async` will become a keyword and `dask.async` will no longer be a valid module name. We move `dask.async` to `dask.scheduler` and deprecate the old module. The documentation has been updated accordingly.
|
An alternative name I considered was |
|
Hrm, Is there any way to warn users? Perhaps keep around async.py and fill it with functions that warn, then call the correct method? |
|
Also thank you for doing this. |
I did that for the two most likely to be used functions. The rest have changed periodically and I would be surprised if they're in use. |
|
Grand. Thanks
…On Tue, May 9, 2017 at 5:02 PM, Jim Crist ***@***.***> wrote:
Is there any way to warn users? Perhaps keep around async.py and fill it
with functions that warn, then call the correct method?
I did that for the two most likely to be used functions. The rest have
changed periodically and I would be surprised if they're in use.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2318 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AASszDuXnzWTKD1m8SPcUop33d7850U_ks5r4NRSgaJpZM4NV3Yd>
.
|
jcrist
changed the title
|
Renamed to |
|
Planning to merge tomorrow if no comment. |
tacaswell
added a commit
to tacaswell/dask
that referenced
this pull request
Oct 27, 2017
async is a proper keyword in python 3.7, finishes work of dask#2318.
jcrist
pushed a commit
that referenced
this pull request
Oct 27, 2017
async is a proper keyword in python 3.7, finishes work of #2318.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 3.7
asyncwill become a keyword anddask.asyncwill no longer be a valid module name. We movedask.asynctodask.schedulerand deprecate the old module. The documentation has been updated accordingly.Fixes #1834.