Dask async warning #195
Merged
Dask async warning #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 27, 2017 16:49
aospy/model.py
Outdated
| @@ -10,8 +10,14 @@ | |||
| from . import utils | |||
|
|
|||
| # Dask must use its serial scheduler if computations are to be performed | |||
| # in parallel using multiprocess | |||
| dask.set_options(get=dask.async.get_sync) | |||
There was a problem hiding this comment.
@spencerahill good catch! It's possible this line may not even be needed anymore now that we use dask.bag for parallel computations. Could you see if the test suite passes with it removed? (In other words we may not need the workaround in this PR).
See this line in #172, where this code was already removed from data_loader.py. Sorry if I missed this there.
There was a problem hiding this comment.
@spencerkclark you're right! Even better. Thanks for catching that.
spencerkclark
approved these changes
Jul 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of dask v0.15, their
asyncmodule that we reference has been renamed tolocal. This PR checks the dask version so that we import from the correct place, thereby avoiding a deprecation message about it.@spencerkclark I don't think this warrants tests, but let me know if you think otherwise.
(Sorry for the accidental incoherent commit message)