Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove skips from doctests (5 of 6) #7864

Merged
merged 3 commits into from
Jul 28, 2021
Merged

Remove skips from doctests (5 of 6) #7864

merged 3 commits into from
Jul 28, 2021

Conversation

zzhengnan
Copy link
Contributor

@zzhengnan zzhengnan commented Jul 3, 2021

@zzhengnan
Copy link
Contributor Author

@jsignell Ready for review.

Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I am not quite sure if these changes make the docs clearer. Particularly the times as floats is kind of hard to interpret. What do you think?

@zzhengnan
Copy link
Contributor Author

@jsignell Could you clarify what you mean by the following?

Particularly the times as floats is kind of hard to interpret.

I too feel something like ('y', (add, 'x', 10), 1435352238.48039, 1435352238.480655, 140285575100160) is hard to interpret, which is precisely the reason why I'm removing them in the PR.

Separately, please see #7865 (comment).

@jsignell
Copy link
Member

Oh 🤦 I guess I was looking at the changes backwards or something? I have no idea. This looks great!

@jsignell jsignell merged commit 724907f into dask:main Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants